Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove invalid casts in options parser #26139

Closed
wants to merge 1 commit into from
Closed

src: remove invalid casts in options parser #26139

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Fixes: #26131

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2626/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 15, 2019
@addaleax addaleax mentioned this pull request Feb 15, 2019
Closed
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20811/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2019
@addaleax
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20820/

@addaleax
Copy link
Member Author

Landed in 35e6070

@addaleax addaleax closed this Feb 18, 2019
@addaleax addaleax deleted the ubsan-1 branch February 18, 2019 08:15
addaleax added a commit that referenced this pull request Feb 18, 2019
@addaleax
src: remove invalid casts in options parser
35e6070 
Fixes: #26131

PR-URL: #26139
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax added a commit that referenced this pull request Feb 18, 2019
@addaleax
src: remove invalid casts in options parser
9524ac4 
Fixes: #26131

PR-URL: #26139
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@addaleax @rvagg
src: remove invalid casts in options parser
778db67 
Fixes: #26131

PR-URL: #26139
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungMinu JungMinu JungMinu approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@hashseed hashseed hashseed approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined Behavior sanitizer: downcast is undefined behavior
5 participants
@addaleax @nodejs-github-bot @hashseed @joyeecheung @JungMinu